Skip to content

Support PyMysql with a version greater than 0.9.3 #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2020
Merged

Support PyMysql with a version greater than 0.9.3 #328

merged 1 commit into from
Aug 22, 2020

Conversation

garenchan
Copy link
Contributor

  1. Since version 0.10.0, PyMysql removed charset_to_encoding method.
  2. It is problematic to compare versions directly through string comparison.

e.g. str('0.10.0') is less than str('0.6.0'), but version('0.10.0') is greater than version('0.6.0').

@mattbornski
Copy link

@baloo this or #326 seem like important candidates for merge, can you review?

@baloo baloo merged commit 51ac1db into julien-duponchelle:master Aug 22, 2020
@javier-sanz javier-sanz mentioned this pull request Aug 24, 2020
Open
@srikiraju
Copy link

@baloo Could we get a release tag with this fix in?

@julien-duponchelle
Copy link
Owner

I can push a release before the end of the week end

@hkwi hkwi mentioned this pull request Sep 18, 2020
Closed
@the4thdoctor
Copy link

Cool, I'll wait for the new release before doing a new release for pg_chameleon.
Ta!

@julien-duponchelle
Copy link
Owner

julien-duponchelle commented Sep 20, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@garenchan @mattbornski @srikiraju @julien-duponchelle @the4thdoctor @baloo